Fix end unconditionally decrementing the split level, but case not incrementing it in a plain select#839
Open
lorenzhs wants to merge 1 commit intoandialbrecht:masterfrom
Open
Fix end unconditionally decrementing the split level, but case not incrementing it in a plain select#839lorenzhs wants to merge 1 commit intoandialbrecht:masterfrom
lorenzhs wants to merge 1 commit intoandialbrecht:masterfrom
Conversation
…crementing it in a plain select
lorenzhs
added a commit
to firebolt-db/firebolt-python-sdk
that referenced
this pull request
Mar 23, 2026
Replace git dependency on lorenzhs/sqlparse fork with a monkey-patch of StatementSplitter._change_splitlevel in statement_formatter.py. The upstream sqlparse project isn't very active and the fix for CASE...END level tracking (andialbrecht/sqlparse#839) was not yet released. PyPI rejects packages with VCS dependencies, so vendoring the fix inline unblocks publishing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes inconsistent level handling of CASE ... END:
_in_caseflag and returns a +1 level diff if it's in a CREATE statementThis led to the level being one lower than it should have been after the CASE WHEN ... END block.
The way this caused trouble was in splitting: combined with some escaping trouble (#838) this led to a query incorrectly being split into two.
Checklist:
pytest)flake8)