TTVA-217 | Add a possibility to define a range for people capacity #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jopesy
approved these changes
Jan 14, 2025
Collaborator
|
Perhaps the field names in Respa admin should be changed slightly (maybe ask for customer feedback on this) to make it clearer what they mean, e.g. "Maksimihenkilömäärä (alaraja)" and "Maksimihenkilömäärä (yläraja)". Currently I at least personally would understand that the resource can be reserved only for 20-25 people. Approved anyway. |
People capacity will be split into two fields: `people_capacity_lower` and `people_capacity_upper` for adding a possibility to define a range of the space capacity. Rename the `people_capacity` field to `people_capacity_lower` in the `Resource` model and keep the data of the original field in this new field. Keep the original name `people_capacity` in the API until UI changes are done. Refs TTVA-217
Add the field `people_capacity_upper` to the `Resource` model and to the Respa admin's resource form. Refs TTVA-217
Make sure that both `people_capacity_lower` and `people_capacity_upper` are considered when filtering resources by people capacity. Refs TTVA-217
japauliina
force-pushed
the
TTVA-217-people-capacity-range
branch
from
548177e to
951091a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People capacity is split into two fields:
people_capacity_lowerandpeople_capacity_upperfor adding a possibility to define a range of the space capacity.Rename the
people_capacityfield topeople_capacity_lowerin theResourcemodel and keep the data of the original field in this new field. However, keep the original namepeople_capacityin the API until UI changes aredone.
Add the field
people_capacity_upperto theResourcemodel and to the Respa admin's resource form.Make sure that both
people_capacity_lowerandpeople_capacity_upperare considered when filtering resources by people capacity.Refs TTVA-217