Skip to content

(feat) Add environments to repository model #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jpascoe wants to merge 1 commit into
base: master
Choose a base branch
from
Open

(feat) Add environments to repository model #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pyartifactory/models/repository.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ class SimpleRepository(BaseModel):
description: Optional[str] = None
url: str
packageType: str
environments: List[str] = ['DEV']
Copy link
Owner

@anancarv anancarv Nov 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add the environment here. The Get repositories response does not contain environment (See Artifactory API)



class BaseRepositoryModel(BaseModel):
Expand All @@ -150,6 +151,7 @@ class BaseRepositoryModel(BaseModel):
projectKey: Optional[str] = None
rclass: RClassEnum
packageType: PackageTypeEnum = PackageTypeEnum.generic
environments: List[str] = ['DEV']
description: Optional[str] = None
notes: Optional[str] = None
includesPattern: str = "**/*"
Expand Down
2 changes: 2 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ classifiers = [
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
Comment on lines +24 to +25
Copy link
Owner

@anancarv anancarv Nov 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to add support to Python 3.13, you will need to add it to the test matrix here

"Topic :: Software Development :: Libraries",
"Topic :: System :: Filesystems",
"Operating System :: OS Independent"
Expand Down