Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/experiment/local/exposure/exposure_service.rb
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ def self.to_exposure_events(exposure, ttl_millis)
elsif variant.value
event_properties['[Experiment] Variant'] = variant.value
end
experiment_key = variant.metadata ? variant.metadata['experimentKey'] : nil
event_properties['[Experiment] Experiment Key'] = experiment_key if experiment_key
event_properties['metadata'] = variant.metadata if variant.metadata

# Build event.
Expand Down
25 changes: 22 additions & 3 deletions spec/experiment/local/exposure/exposure_service_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,17 @@
value: 'on'
)
empty_variant = AmplitudeExperiment::Variant.new
with_experiment_key = AmplitudeExperiment::Variant.new(
key: 'treatment',
value: 'treatment',
metadata: {
'segmentName' => 'All Other Users',
'flagType' => 'experiment',
'flagVersion' => 10,
'default' => false,
'experimentKey' => 'exp-1'
}
)
results = {
'basic' => basic,
'different_value' => different_value,
Expand All @@ -105,13 +116,14 @@
'holdout' => holdout,
'partial_metadata' => partial_metadata,
'empty_metadata' => empty_metadata,
'empty_variant' => empty_variant
'empty_variant' => empty_variant,
'with_experiment_key' => with_experiment_key
}
exposure = AmplitudeExperiment::Exposure.new(user, results)
events = AmplitudeExperiment::ExposureService.to_exposure_events(exposure, AmplitudeExperiment::DAY_MILLIS)
# Should exclude default (default=true) only
# basic, different_value, mutex, holdout, partial_metadata, empty_metadata, empty_variant = 7 events
expect(events.length).to eq(7)
# basic, different_value, mutex, holdout, partial_metadata, empty_metadata, empty_variant, with_experiment_key = 8 events
expect(events.length).to eq(8)

events.each do |event|
expect(event.event_type).to eq('[Experiment] Exposure')
Expand All @@ -130,6 +142,13 @@
end
expect(event.event_properties['metadata']).to eq(variant.metadata) if variant.metadata

# Validate experiment key is lifted to top-level event property when present
if flag_key == 'with_experiment_key'
expect(event.event_properties['[Experiment] Experiment Key']).to eq('exp-1')
else
expect(event.event_properties).not_to have_key('[Experiment] Experiment Key')
end

# Validate user properties
flag_type = variant.metadata ? variant.metadata['flagType'] : nil
if flag_type == 'mutual-exclusion-group'
Expand Down
Loading