Skip to content

Conversation

@ENewmeration
Copy link

Summary

Relax the concurrent-ruby versioning to minor versions (which is blocking us from upgrading)

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

@ENewmeration
Copy link
Author

@kyeh-amp Looks like it's running my PR without api key and secrets. you can see they are blank in my build
image

versus *** out in your PRs builds
image

Is this a permission things related to my user because I opened the PR that it's not grabbing values from secrets file? and if so can you reopen up this PR under your authorship?

These specific tests fail that rely on key + secret env variables fail locally on main for me even before this change for what I assume is similar-ish reason (I don't have local .env with these values so environment is blank as well there)

@kyeh-amp
Copy link
Collaborator

kyeh-amp commented Dec 4, 2025

@ENewmeration yeah you got it. I was running it a few times to see if I could get it to work on my end with some tweaking but those didn't work out the way I thought they would. Anyway, I cut #79. I will cut a release when checks pass. I'll close this with a note when it's done.

@kyeh-amp
Copy link
Collaborator

kyeh-amp commented Dec 4, 2025

This change was included in today's release of v1.7.1. Closing this now.

@kyeh-amp kyeh-amp closed this Dec 4, 2025
@ENewmeration
Copy link
Author

v1.7.1

Thank you so much @kyeh-amp !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants