Skip to content

fix: package evaluation code into AmplitudeExperiment::Evaluation module #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyeh-amp merged 3 commits into from
Dec 4, 2025
Merged

fix: package evaluation code into AmplitudeExperiment::Evaluation module #77

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83841fd
fix: package evaluation code into AmplitudeExperiment::Evaluation module
kyeh-amp Dec 3, 2025
ccb4c8a
refactor: fix linting issues
kyeh-amp Dec 3, 2025
8fa63b2
docs: fix pr template link for commit title convetions
kyeh-amp Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ Please fill out the following sections to help us quickly review your pull reque

### Checklist

* [ ] Does your PR title have the correct [title format](https://github.com/amplitude/experiments-ruby-server/blob/main/CONTRIBUTING.md#pr-commit-title-conventions)?
* Does your PR have a breaking change?: <!-- Yes or no -->
- [ ] Does your PR title have the correct [title format](https://github.com/amplitude/experiment-ruby-server/blob/main/CONTRIBUTING.md#pr-commit-title-conventions)?
- Does your PR have a breaking change?: <!-- Yes or no -->
7 changes: 1 addition & 6 deletions lib/amplitude-experiment.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,7 @@
require 'experiment/cohort/cohort_sync_config'
require 'experiment/deployment/deployment_runner'
require 'experiment/util/poller'
require 'experiment/evaluation/evaluation'
require 'experiment/evaluation/flag'
require 'experiment/evaluation/murmur3'
require 'experiment/evaluation/select'
require 'experiment/evaluation/semantic_version'
require 'experiment/evaluation/topological_sort'
require 'experiment/evaluation'

# Amplitude Experiment Module
module AmplitudeExperiment
Expand Down
6 changes: 6 additions & 0 deletions lib/experiment/evaluation.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
require 'experiment/evaluation/evaluation'
require 'experiment/evaluation/flag'
require 'experiment/evaluation/murmur3'
require 'experiment/evaluation/select'
require 'experiment/evaluation/semantic_version'
require 'experiment/evaluation/topological_sort'
Loading