feat: add exposure service #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new exposure service to track feature flag exposures, deprecating the existing assignment service. The new exposure tracking provides improved functionality including per-flag event tracking and a tracks_exposure option for evaluate_v2.
Key changes:
- Introduced
ExposureService,ExposureFilter,Exposure, andExposureConfigclasses to replace assignment tracking - Added
tracks_exposureparameter toEvaluateOptionsfor controlling exposure tracking behavior - Deprecated assignment-related classes (
AssignmentService,AssignmentFilter,Assignment,AssignmentConfig)
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/experiment/local/exposure/exposure_service.rb | Implements the core exposure tracking service with event generation logic |
| lib/experiment/local/exposure/exposure_filter.rb | Provides deduplication filtering for exposure events using LRU cache |
| lib/experiment/local/exposure/exposure.rb | Defines the Exposure data structure representing user's flag exposures |
| lib/experiment/local/exposure/exposure_config.rb | Configuration class for exposure tracking settings |
| lib/experiment/local/evaluate_options.rb | New options class for evaluate_v2 including tracks_exposure flag |
| lib/experiment/local/config.rb | Updates configuration to support both assignment and exposure configs |
| lib/experiment/local/client.rb | Integrates exposure service into client and updates evaluate_v2 signature |
| lib/experiment/local/assignment/*.rb | Adds deprecation notices to assignment-related classes |
| lib/amplitude-experiment.rb | Adds require statements for new exposure modules |
| spec/experiment/local/exposure/*.rb | Comprehensive test coverage for exposure functionality |
| spec/experiment/local/client_spec.rb | Integration test verifying tracks_exposure behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
📝 Documentation updates detected! New suggestion: Document exposure tracking for Ruby Experiment SDK local evaluation |
kyeh-amp
approved these changes
Nov 18, 2025
|
📝 Documentation updates detected! New suggestion: Document exposure tracking for Ruby Experiment SDK local evaluation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding exposure service, deprecating assignment service, and adding tracksExposure to evaluate options.
Checklist