Skip to content

chore: upgrade playwright #1668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daniel-graham-amplitude wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: upgrade playwright #1668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e-session-replay.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
permissions:
pull-requests: write
container:
image: mcr.microsoft.com/playwright:v1.55.0
image: mcr.microsoft.com/playwright:v1.59.1
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The container image was updated to Playwright v1.59.1, but the repo is still pinned to @playwright/test 1.55.0 (package.json:54). In Playwright’s official images, the preinstalled browsers are tied to the image version, so this mismatch can produce inconsistent CI behavior. Consider upgrading @playwright/test to 1.59.1 (and lockfile) or aligning the image tag to 1.55.0.

Suggested change
image: mcr.microsoft.com/playwright:v1.59.1
image: mcr.microsoft.com/playwright:v1.55.0

Copilot uses AI. Check for mistakes.

steps:
- name: Check out repository
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
if: github.actor != 'dependabot[bot]'
runs-on: ubuntu-latest
container:
image: mcr.microsoft.com/playwright:v1.55.0
image: mcr.microsoft.com/playwright:v1.59.1
Copy link
Copy Markdown

@cursor cursor Bot Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Playwright container version mismatches npm package version

High Severity

The container image is upgraded to mcr.microsoft.com/playwright:v1.59.1 but @playwright/test in package.json remains pinned at 1.55.0. Playwright requires the container version and npm package version to match exactly — a mismatch causes browser launch failures due to incompatible executable paths and protocol versions. This will break E2E tests in all three workflows.

Additional Locations (2)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 933bd6d. Configure here.

Copy link
Copy Markdown
Contributor

@Mercy811 Mercy811 Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daniel-graham-amplitude this looks like a valid comment

Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow now runs in the Playwright v1.59.1 container, but the workspace devDependency @playwright/test is pinned to 1.55.0 (package.json:54). That version skew can cause mismatched bundled browsers vs driver expectations inside the container. Recommend updating @playwright/test to 1.59.1 (and lockfile) or matching the container image tag to the installed Playwright version.

Suggested change
image: mcr.microsoft.com/playwright:v1.59.1
image: mcr.microsoft.com/playwright:v1.55.0

Copilot uses AI. Check for mistakes.

steps:
- name: Check out git repository
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
runs-on: ubuntu-latest
needs: [authorize]
container:
image: mcr.microsoft.com/playwright:v1.55.0
image: mcr.microsoft.com/playwright:v1.59.1
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Playwright Docker image tag is now v1.59.1, but the repo’s Playwright test runner is pinned to @playwright/test 1.55.0 (see package.json:54). Mixing a newer image (with its bundled browsers) with an older Playwright npm version can lead to browser/driver mismatches and flaky or failing runs. Consider bumping @playwright/test (and lockfile) to 1.59.1 to keep versions aligned, or keep the container tag in sync with the npm dependency version.

Suggested change
image: mcr.microsoft.com/playwright:v1.59.1
image: mcr.microsoft.com/playwright:v1.55.0

Copilot uses AI. Check for mistakes.

steps:
- name: Check out git repository
Expand Down
Loading