Pin notes #622
Open
Pin notes #622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is_pinned parameter
MiraMeeeow
reviewed
Jan 14, 2026
src/AmoCRM/Models/NoteModel.php
Outdated
| * @param bool|null $isPinned | ||
| * @return NoteModel | ||
| */ | ||
| public function setIsPinned(?bool $isPinned): NoteModel |
ticket: INTEGR-2920
dnklbgn
reviewed
Jan 21, 2026
Comment on lines
+216
to
+222
| public function pin(NoteModel $model): void | ||
| { | ||
| try { | ||
| $this->request->post(sprintf('%s/%d/pin', $this->getMethod(), $model->getId())); | ||
| } catch (AmoCRMApiNoContentException $exception) { | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Из того, что я вижу в библиотеке, подобные методы обычно возвращали bool в случае, если падал AmoCRMApiNoContentException. \AmoCRM\EntitiesServices\Traits\LinkMethodsTrait::unlink в пример. Давай не будем изобретать что-то новое и поддержим подобную логику
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin notes