Skip to content

Conversation

@saeedkargosha
Copy link
Contributor

1-rewrite all function iOS with swift
2-add function for generating EC
3-add function for generating CSR
4-add function for getting PublicKey with DER
5-export Constance ECDSA algorithm

@amitaymolko
Copy link
Owner

Hey @saeedkargosha
Thanks for this!
Does this PR close #69 ?

@saeedkargosha
Copy link
Contributor Author

you're welcome
Yeah.

@Ben305
Copy link

Ben305 commented Apr 26, 2020

👍

@amitaymolko Any chance to get this merged and released soon?

@amitaymolko amitaymolko reopened this Apr 26, 2020
@amitaymolko
Copy link
Owner

amitaymolko commented Apr 26, 2020

Hey Ben,

I have tested this PR and it seems to be working well.
This PR increases the minimal React Native version so I'm considering releasing it as a new major version to not affect current users of the lib.
I'm aware that this PR also fixes known issues with newer RN versions.
I will do my best to get to this ASAP.

Cheers

P.S accidentally closed the PR, reopened

@Ben305
Copy link

Ben305 commented Apr 26, 2020

A new major version would be perfectly fine, I‘d like to use this package for a new app based on RN 0.62.

@amitaymolko amitaymolko changed the base branch from master to feature/swift_rewrite May 10, 2020 16:26
@amitaymolko amitaymolko merged commit d81d593 into amitaymolko:feature/swift_rewrite May 10, 2020
@amitaymolko
Copy link
Owner

merging into a branch to fix the example project and docs, and then I will release a version

@amitaymolko
Copy link
Owner

After fixing the example project and 2 small issues I've released this under v2.0.0

@Ben305
Copy link

Ben305 commented May 10, 2020

Thank you @amitaymolko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants