sadf #6
Merged
sadf #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| routerModule = require(mod) | ||
| } catch { | ||
| // require failed, module not available | ||
| } |
There was a problem hiding this comment.
Bug: Synchronous require in ESM module fails at runtime
The code attempts to use require() in an ESM module (package.json has "type": "module"). The require function is not available in ESM contexts or browser environments, causing this code path to always fail. The fallback logic at line 48 will always throw an error when react-router-dom isn't statically imported, making the optional peer dependency non-functional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Makes React Router integration optional with a lazy
useLocationimport, wraps breadcrumb labels inTypography, and bumps package/version metadata.useReactRouterBreadcrumbs: replace directreact-router-domimport with a lazy/dynamicuseLocationresolver; throws a clear error if the package isn’t installed.react-router-domas an optional peer and dev dependency; update keywords.Typographyinstead ofBoxinContent.0.1.2.Written by Cursor Bugbot for commit 657c6f4. This will update automatically on new commits. Configure here.