Skip to content

Conversation

@bnachtweh
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request removes the external qs dependency and replaces it with a custom stringify implementation to handle query parameter serialization. This change aims to improve performance by eliminating an external dependency.

Changes:

  • Implemented custom stringify function to replace qs.stringify functionality
  • Added IStringifyQueryOptions interface to define configuration options
  • Removed qs package dependency from package.json and pnpm-lock.yaml
  • Added comprehensive tests for the new stringify options (maxDepth, skipNulls, separator)
  • Updated API documentation to reflect the new optional parameters

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/url.ts Implements custom stringify function with recursive encoding logic and adds options parameter to setQueryParams
types/index.ts Defines IStringifyQueryOptions interface for query stringification configuration
tests/url.spec.ts Adds tests for new options (maxDepth, skipNulls, separator) and nested object handling
package.json Removes qs dependency
pnpm-lock.yaml Removes qs and its transitive dependencies
docs/api.md Updates setQueryParams documentation to include options parameter
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI commented Jan 16, 2026

@bnachtweh I've opened a new pull request, #21, to work on those changes. Once the pull request is ready, I'll request review from you.

@bnachtweh bnachtweh merged commit 5aa52b5 into main Jan 16, 2026
4 checks passed
@bnachtweh bnachtweh deleted the 19-add-query-string-parser-with-smaller-footprint branch January 16, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add query string parser with smaller footprint

2 participants