-
Notifications
You must be signed in to change notification settings - Fork 0
perf(query): remove need for external dependency #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(query): remove need for external dependency #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request removes the external qs dependency and replaces it with a custom stringify implementation to handle query parameter serialization. This change aims to improve performance by eliminating an external dependency.
Changes:
- Implemented custom
stringifyfunction to replaceqs.stringifyfunctionality - Added
IStringifyQueryOptionsinterface to define configuration options - Removed
qspackage dependency from package.json and pnpm-lock.yaml - Added comprehensive tests for the new stringify options (maxDepth, skipNulls, separator)
- Updated API documentation to reflect the new optional parameters
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/url.ts | Implements custom stringify function with recursive encoding logic and adds options parameter to setQueryParams |
| types/index.ts | Defines IStringifyQueryOptions interface for query stringification configuration |
| tests/url.spec.ts | Adds tests for new options (maxDepth, skipNulls, separator) and nested object handling |
| package.json | Removes qs dependency |
| pnpm-lock.yaml | Removes qs and its transitive dependencies |
| docs/api.md | Updates setQueryParams documentation to include options parameter |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@bnachtweh I've opened a new pull request, #21, to work on those changes. Once the pull request is ready, I'll request review from you. |
No description provided.