Skip to content

Fix hover card covering delete button in sessions sidebar#1246

Open
angaduom wants to merge 1 commit intoambient-code:mainfrom
angaduom:fix-hover-card-delete-button
Open

Fix hover card covering delete button in sessions sidebar#1246
angaduom wants to merge 1 commit intoambient-code:mainfrom
angaduom:fix-hover-card-delete-button

Conversation

@angaduom
Copy link
Copy Markdown

@angaduom angaduom commented Apr 8, 2026

When clicking the three-dot menu on a session in the recents sidebar, the hover card would appear over the dropdown menu, blocking access to the delete button and other actions.

Restructured the HoverCard to only wrap the session link instead of the entire row, preventing the hover card from appearing when interacting with the dropdown menu.

Summary by CodeRabbit

  • Refactor
    • Restructured session sidebar layout to reorganize hover card and action menu positioning.

When clicking the three-dot menu on a session in the recents sidebar,
the hover card would appear over the dropdown menu, blocking access to
the delete button and other actions.

Restructured the HoverCard to only wrap the session link instead of
the entire row, preventing the hover card from appearing when
interacting with the dropdown menu.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3a809b93-dc9b-4ba2-90e1-95678520d324

📥 Commits

Reviewing files that changed from the base of the PR and between 4c8486e and 0f73dcc.

📒 Files selected for processing (1)
  • components/frontend/src/app/projects/[name]/sessions/[sessionName]/components/sessions-sidebar.tsx

📝 Walkthrough

Walkthrough

Restructured DOM hierarchy in the sessions sidebar component. The HoverCard and SidebarSessionActions elements are reorganized from a nested structure to sibling elements within the session row container, maintaining existing hover and interaction logic.

Changes

Cohort / File(s) Summary
Sessions Sidebar DOM Restructuring
components/frontend/src/app/projects/[name]/sessions/[sessionName]/components/sessions-sidebar.tsx
Repositioned HoverCard (wrapping Link) and SidebarSessionActions from a nested parent-child relationship to adjacent siblings within the session row div. Hover card trigger/content behavior unchanged; DOM tree organization optimized for layout management.

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (2 warnings, 1 inconclusive)

Check name Status Explanation Resolution
Title check ⚠️ Warning Title does not follow Conventional Commits format (missing type prefix like 'fix:', 'feat:', etc.). Reformat title to 'fix(sessions-sidebar): prevent hover card from covering delete button' to comply with Conventional Commits format.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Security And Secret Handling ❓ Inconclusive Unable to execute shell commands to analyze the file; cannot verify security posture without file contents. Provide the file content directly or confirm file location and access permissions for analysis.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Performance And Algorithmic Complexity ✅ Passed DOM restructuring poses no performance concerns; proper pagination (limit 20, initial 10), correct memoization, bounded loops (≤20 items), no O(n²) or N+1 patterns detected.
Kubernetes Resource Safety ✅ Passed Custom Kubernetes resource safety check not applicable. PR modifies only sessions-sidebar.tsx, a frontend React/TypeScript component for UI hover card positioning.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ktdreyer
Copy link
Copy Markdown
Contributor

ktdreyer commented Apr 8, 2026

Thanks! I noticed this problem also today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants