Skip to content

fix: raise DiscretizationError when rydbergLocal params missing #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterkomar-aws merged 1 commit into from
Jun 3, 2026
+22 −5
Merged

fix: raise DiscretizationError when rydbergLocal params missing #1265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/braket/ahs/local_detuning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

from __future__ import annotations

from braket.ahs.discretization_types import DiscretizationProperties
from braket.ahs.discretization_types import DiscretizationError, DiscretizationProperties
from braket.ahs.field import Field
from braket.ahs.hamiltonian import Hamiltonian
from braket.ahs.pattern import Pattern
Expand Down Expand Up @@ -149,12 +149,19 @@ def discretize(self, properties: DiscretizationProperties) -> LocalDetuning:

Returns:
LocalDetuning: A new discretized LocalDetuning.

Raises:
DiscretizationError: If local detuning parameters are not available from
the device properties.
"""
local_detuning_parameters = properties.rydberg.rydbergLocal
time_resolution = (
local_detuning_parameters.timeResolution if local_detuning_parameters else None
)
if not local_detuning_parameters:
raise DiscretizationError(
"Local detuning parameters (rydbergLocal) are not available from the device "
"properties. Ensure that the device supports local detuning and that the "
"rydbergLocal capability data is returned by GetDevice."
)
discretized_magnitude = self.magnitude.discretize(
time_resolution=time_resolution,
time_resolution=local_detuning_parameters.timeResolution,
)
return LocalDetuning(discretized_magnitude)
10 changes: 10 additions & 0 deletions test/unit_tests/braket/ahs/test_local_detuning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

import pytest

from braket.ahs.discretization_types import DiscretizationError
from braket.ahs.hamiltonian import Hamiltonian
from braket.ahs.local_detuning import LocalDetuning
from braket.timings.time_series import StitchBoundaryCondition
Expand Down Expand Up @@ -134,6 +135,15 @@ def test_discretize():
assert discretized_field.magnitude == magnitude_mock.discretize.return_value


def test_discretize_raises_when_rydberg_local_missing():
magnitude_mock = Mock()
mock_properties = Mock()
mock_properties.rydberg.rydbergLocal = None
field = LocalDetuning(magnitude=magnitude_mock)
with pytest.raises(DiscretizationError, match="rydbergLocal"):
field.discretize(mock_properties)


@pytest.mark.xfail(raises=ValueError)
def test_iadd_to_itself(default_local_detuning):
default_local_detuning += Hamiltonian(Mock())
Loading