Update SIMPLETEST_BASE_URL to use DDEV_PRIMARY_URL#19
Merged
Conversation
Owner
|
Looks good to me, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
When using xdebug in a test the test itself uses the ddev hostname as the server name, but the SUT uses
web. This means we need two sets of path mappings. If you have multiple projects open and listening for connections they might both have awebserver and conflict.How This PR Solves The Issue
Just use the ddev hostname instead of hardcoding to http://web
Manual Testing Instructions
Automated Testing Overview
Release/Deployment Notes