Skip to content

Fix GitHub sync details blank state#138

Merged
alvarosanchez merged 2 commits into
mainfrom
codex/fix-github-sync-details-ui
May 25, 2026
Merged

Fix GitHub sync details blank state#138
alvarosanchez merged 2 commits into
mainfrom
codex/fix-github-sync-details-ui

Conversation

@alvarosanchez
Copy link
Copy Markdown
Owner

Summary

  • Prefer slot-provided issue context for the GitHub Sync task detail surface before falling back to useHostContext().
  • Replace the post-loading blank panel with an explicit GitHub sync details troubleshooting state when issue context cannot be resolved.
  • Add regression coverage and update README/SPEC guidance for the issue detail behavior.

Validation

  • pnpm exec tsx --test --test-name-pattern "resolveGitHubIssue" tests/plugin.spec.ts
  • pnpm typecheck
  • pnpm test
  • pnpm build
  • pnpm test:e2e against disposable Paperclip 2026.517.0

Model Used

  • Model ID/version: GPT-5 Codex via OpenAI Codex Desktop. Exact backend revision is not exposed to the agent runtime.
  • Context window size: not exposed to the agent runtime.
  • Capabilities: code reasoning, shell and GitHub CLI tool use, local build/test/e2e verification.

Copilot AI review requested due to automatic review settings May 25, 2026 10:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves the GitHub Sync issue detail tab experience by preferring slot-provided issue context over useHostContext(), and by replacing the “blank panel” failure mode with an explicit troubleshooting/unresolved state when issue context cannot be resolved.

Changes:

  • Prefer slot context for task/detail tab issue context resolution, with host context as fallback.
  • Introduce an explicit unresolved detail-tab state and render a troubleshooting panel instead of returning null.
  • Add regression tests and update README/SPEC guidance for issue detail behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/ui/index.tsx Adds slot-context resolution, introduces unresolved state, and renders troubleshooting UI for missing/unresolvable issue context.
tests/plugin.spec.ts Adds regression coverage for unresolved state and slot-context preference logic.
SPEC.md Updates specification language for issue detail context precedence and unresolved behavior.
README.md Updates documentation to mention troubleshooting details when issue context can’t be resolved.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/ui/index.tsx
@alvarosanchez alvarosanchez merged commit 157f2f6 into main May 25, 2026
1 check passed
@alvarosanchez alvarosanchez deleted the codex/fix-github-sync-details-ui branch May 25, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants