Fix GitHub sync details blank state#138
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves the GitHub Sync issue detail tab experience by preferring slot-provided issue context over useHostContext(), and by replacing the “blank panel” failure mode with an explicit troubleshooting/unresolved state when issue context cannot be resolved.
Changes:
- Prefer slot context for task/detail tab issue context resolution, with host context as fallback.
- Introduce an explicit
unresolveddetail-tab state and render a troubleshooting panel instead of returningnull. - Add regression tests and update README/SPEC guidance for issue detail behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/ui/index.tsx |
Adds slot-context resolution, introduces unresolved state, and renders troubleshooting UI for missing/unresolvable issue context. |
tests/plugin.spec.ts |
Adds regression coverage for unresolved state and slot-context preference logic. |
SPEC.md |
Updates specification language for issue detail context precedence and unresolved behavior. |
README.md |
Updates documentation to mention troubleshooting details when issue context can’t be resolved. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useHostContext().Validation
pnpm exec tsx --test --test-name-pattern "resolveGitHubIssue" tests/plugin.spec.tspnpm typecheckpnpm testpnpm buildpnpm test:e2eagainst disposable Paperclip2026.517.0Model Used