Show local trusted auth controls#133
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Sync plugin’s settings UI to decouple “Paperclip board access is required” from “board-access setup controls are visible,” ensuring local trusted deployments can still configure board access while keeping GitHub token propagation available across all deployment modes.
Changes:
- Introduces a shared
resolvePaperclipAuthControlsPolicythat separately drives board-access requirement vs. visibility, while keeping token-propagation visibility always on. - Updates the settings UI to render board-access setup for
authenticatedandlocal_trusted(but only require it for sync onauthenticated) and to keep agent token propagation active regardless of mode. - Expands coverage across unit tests, smoke test, SPEC, and README to reflect the new local trusted behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/plugin.spec.ts | Adds policy-focused tests for local trusted visibility and always-on token propagation. |
| src/ui/index.tsx | Replaces board-access gating with policy-driven visibility; removes propagation gate tied to board-access requirement. |
| src/paperclip-health.ts | Adds PaperclipAuthControlsPolicy and a resolver to centralize auth-controls decisions. |
| SPEC.md | Updates requirements to reflect board-access visibility on local trusted and propagation visibility in all modes. |
| scripts/e2e/run-paperclip-smoke.mjs | Adjusts smoke assertions for local trusted board-access visibility and verifies propagation control appears. |
| README.md | Updates docs to describe board-access controls for local trusted + always-available agent token propagation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GITHUB_TOKENsecret ref.Root Cause
The UI used the strict
boardAccessRequiredflag as both the render gate for board access setup and the render/behavior gate for agent token propagation. That hid setup onlocal_trusteddeployments even though some host API paths can still need board credentials, and it skipped propagation on non-authenticated deployment modes.Validation
pnpm typecheckpnpm exec tsx --test --test-name-pattern "Paperclip auth controls policy|fetchPaperclipHealth" tests/plugin.spec.tspnpm test(255 passing tests)pnpm buildpnpm test:e2eagainst disposablepaperclipai@2026.517.0inlocal_trustedmodegit diff --checkModel Used