Skip to content

[DPG] Please consider the following formatting changes to #12365 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alibuild wants to merge 1 commit into from
Closed

[DPG] Please consider the following formatting changes to #12365 #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@
int64_t tsSOR = 0; // dummy start-of-run timestamp
int64_t tsEOR = 1; // dummy end-of-run timestamp

if (runNumber >= 500000) {

Check failure on line 377 in DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
auto runInfo = o2::parameters::AggregatedRunInfo::buildAggregatedRunInfo(o2::ccdb::BasicCCDBManager::instance(), runNumber);
// first bc of the first orbit
bcSOR = runInfo.orbitSOR * o2::constants::lhc::LHCMaxBunches;
Expand Down Expand Up @@ -526,7 +526,7 @@

// ### collision loop
for (const auto& col : cols) {
if (std::abs(col.posZ()) > 10)

Check failure on line 529 in DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
continue;

const auto& foundBC = col.foundBC_as<BCsRun3>();
Expand All @@ -551,7 +551,7 @@

auto bcIndex = foundBC.globalIndex();
// bool noNearbyActivity = (vPastActivity[bcIndex] == 0 && vFutureActivity[bcIndex] == 0);
bool noPastActivity = (vPastActivity[bcIndex] == 0 );
bool noPastActivity = (vPastActivity[bcIndex] == 0);

// ### count tracks of different types
int nPVtracks = 0;
Expand All @@ -562,17 +562,17 @@
if (!track.isPVContributor()) {
continue;
}
if (track.itsNCls() < 5)

Check failure on line 565 in DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
continue;
if (track.pt() < 0.2 || track.pt() > 10)

Check failure on line 567 in DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
continue;
if (std::abs(track.eta()) > 0.8)

Check failure on line 569 in DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
continue;

nPVtracks++;
nTOFtracks += track.hasTOF();

if (track.hasITS() && track.hasTPC() && track.tpcNClsFound() > 50 && track.tpcNClsCrossedRows() > 50 && track.tpcChi2NCl() < 4)

Check failure on line 575 in DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
nGlobalTracks++;
} // end of track loop

Expand All @@ -592,11 +592,11 @@
// bool badVzDiff = hasFT0 && (multT0M > 5000) && (diffVz < -2.5 || diffVz > 2.5);
float meanDiff = 0.0; // cm
// O-O
if (lastRunNumber == 564356)

Check failure on line 595 in DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
meanDiff = -0.01;
if (lastRunNumber == 564359)

Check failure on line 597 in DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
meanDiff = -0.17;
if (lastRunNumber == 564373)

Check failure on line 599 in DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
meanDiff = 0.99;
if (lastRunNumber == 564374)
meanDiff = 0.57;
Expand All @@ -607,7 +607,7 @@
meanDiff = -0.60;

// float stdDev = (multT0M > 20) ? 0.54 + 6.46 / sqrt(multT0M) : 2.0; // cm
float stdDev = (multT0M > 10) ? 0.144723 + 13.5345 / sqrt(multT0M) : 1.5; // cm

Check failure on line 610 in DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[std-prefix] 

Use std:: prefix for names from the std namespace.
if (multT0M > 4000)
stdDev = 0.35; // cm
bool badVzDiff = diffVz < (meanDiff - stdDev * nSigmaForVzDiff - safetyDiffMargin) || diffVz > (meanDiff + stdDev * nSigmaForVzDiff + safetyDiffMargin);
Expand Down
Loading