Skip to content

feat: plug rubocop#25

Merged
redox merged 2 commits intoaltertable-ai:mainfrom
albert20260301:feat/24-plug-rubocop
Mar 9, 2026
Merged

feat: plug rubocop#25
redox merged 2 commits intoaltertable-ai:mainfrom
albert20260301:feat/24-plug-rubocop

Conversation

@albert20260301
Copy link
Contributor

Resolves #24

@redox
Copy link
Member

redox commented Mar 9, 2026

@albert20260301 can you rebase & fix the conflicts

@albert20260301
Copy link
Contributor Author

albert20260301 commented Mar 9, 2026

On it! I'll rebase on main to pull in the recent v1.0.0 changes, resolve any conflicts, make sure rubocop and rspec still pass, and push the update.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: "Typing"

- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: "3.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
ruby-version: "3.3"
ruby-version: "3.4"

@albert20260301
Copy link
Contributor Author

albert20260301 commented Mar 9, 2026

Just addressed the review! I've updated the lint job to run on Ruby 3.4 and renamed the typing job to just Typing. Everything is pushed!

@redox redox merged commit 1b375d5 into altertable-ai:main Mar 9, 2026
6 checks passed
redox pushed a commit that referenced this pull request Mar 9, 2026
🤖 I have created a release *beep* *boop*
---


##
[1.1.0](altertable/v1.0.0...altertable/v1.1.0)
(2026-03-09)


### Features

* plug rubocop
([#25](#25))
([1b375d5](1b375d5)),
closes [#24](#24)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plug Rubocop

2 participants