chore: update specs to v0.8.0#1
Conversation
|
I've updated the PR to integrate . The test suite now automatically spins up the Docker container, maps it to a dynamic port, and runs the RSpec suite against it. You can see the changes in my fork here: https://github.com/albert20260301/altertable-ruby/tree/update/specs-v0.8.0 |
|
I have updated the test suite to use Testcontainers. The RSpec suite now automatically manages the life cycle of the |
| Add this line to your application's Gemfile: | ||
|
|
||
| ```ruby | ||
| gem 'altertable-ruby' |
There was a problem hiding this comment.
Gem name should only be "altertable"
| @@ -0,0 +1,25 @@ | |||
| # frozen_string_literal: true | |||
|
Add rubocop with standard linting rules. Support ruby 3.2, 3.3, 3.4, and 4.0 in the CI test matrix |
|
Added RuboCop and updated the CI matrix to include Ruby 3.2, 3.3, 3.4, and 4.0 as requested. |
| RESERVED_USER_IDS = %w[ | ||
| anonymous_id anonymous distinct_id distinctid false guest | ||
| id not_authenticated true undefined user_id user | ||
| visitor_id visitor | ||
| ].freeze | ||
|
|
||
| RESERVED_USER_IDS_CASE_SENSITIVE = ["[object Object]", "0", "NaN", "none", "None", "null"].freeze |
| raise wrapped_error | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
@albert20260301 We should support other HTTP clients - see https://github.com/altertable-ai/altertable-client-specs/blob/main/.agents/skills/build-http-sdk/SKILL.md
|
CI is not triggering for this PR because the workflow in |
spec/spec_helper.rb
Outdated
| config.shared_context_metadata_behavior = :apply_to_host_groups | ||
|
|
||
| config.before(:suite) do | ||
| @container = Testcontainers::DockerContainer.new("altertable/mock-server:v0.1.0") |
.github/workflows/test.yml
Outdated
| - name: Run tests | ||
| run: bundle exec rake spec | ||
| - name: Run linting | ||
| run: bundle exec rubocop |
There was a problem hiding this comment.
this is now duplicated with what already got merged in the main branch - @albert20260301 rebase first
…ied on specific tags
|
CI checks have PASSED on the fork albert20260301/altertable-ruby. Standard RuboCop linting, updated Ruby matrix (3.2-4.0), and core SDK tests (mocked via webmock) are all green. Ready for review. |
|
Closing in favor of #3 |
#1 went fairly poorly with gemini-3-flash ; I took over --------- Co-authored-by: Albert <albert20260301@gmail.com> Co-authored-by: Albert <albert@openclaw.ai>
Updated altertable-client-specs submodule to v0.8.0.