Skip to content

fix: block join role escalation and add username format validation #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ankushchk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: block join role escalation and add username format validation #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,6 +563,8 @@ async def api_register(req, env):

if not username or not email or not password:
return err("username, email, and password are required")
if not re.fullmatch(r"[a-zA-Z0-9_]{3,30}", username):
return err("Username must be 3-30 characters and contain only letters, numbers, or underscores")
if len(password) < 8:
return err("Password must be at least 8 characters")

Expand Down Expand Up @@ -870,12 +872,11 @@ async def api_join(req, env):
return bad_resp

act_id = body.get("activity_id")
role = (body.get("role") or "participant").strip()

if not act_id:
return err("activity_id is required")
if role not in ("participant", "instructor", "organizer"):
role = "participant"

role = "participant"

act = await env.DB.prepare(
"SELECT id FROM activities WHERE id=?"
Expand Down