Skip to content

Remove enable welsh column#2644

Open
thomasiles wants to merge 2 commits intomainfrom
remove-enable-welsh-column
Open

Remove enable welsh column#2644
thomasiles wants to merge 2 commits intomainfrom
remove-enable-welsh-column

Conversation

@thomasiles
Copy link
Contributor

Remove the welsh_enabled column from the group table

Trello card: https://trello.com/c/gI4COCYo/2863-remove-welsh-feature-flag

The column has already been ignored so it should be safe to remove.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

The welsh_enabled column in Group was used for the welsh_enabled feature
flag. All uses of the feature flag have been removed and the column has
been ignored.

This commit adds migration to remove the column.
The welsh_enabled column has been dropped from the Group table.

We no longer need to ignore the column.
@sonarqubecloud
Copy link

@github-actions
Copy link

🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2644.admin.review.forms.service.gov.uk/

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@thomasiles thomasiles marked this pull request as ready for review March 18, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants