Open
Conversation
The preview functionality in the ViewComponent library has changed its configuration API since we initially configured it, breaking all of our component preview links. This commit updates to the new configuration, and adds a test so we'll be alerted if config changes break the previews again in future. This commit copies the fix from alphagov/forms-runner#1833. Co-authored-by: David Biddle <contact@davidbiddle.co.uk>
In commit 94da7e7 we changed the call signature for the constructor of the page list component error summary, but the calls in the component preview weren't updated because nothing was testing if they were working. Now the component previews are working again, the previews for are complaining. This commit updates the specs to make the component preview tests pass again.
lfdebrux
force-pushed
the
ldeb-fix-view-component-previews
branch
from
2196e19 to
fe32ae7
Compare
|
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2636.admin.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
DavidBiddle
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
The preview functionality in the ViewComponent library has changed its configuration API since we initially configured it, breaking all of our component preview links.
This PR updates to the new configuration, and adds a test so we'll be alerted if config changes break the previews again in future.
This PR copies the fix from alphagov/forms-runner#1833.
Things to consider when reviewing