fix #135 #147
Open
fix #135 #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@PietrH or @peterdesmet can one of you look if this works for you? I think this setup balances flexibility with usability but it would be good to see if it also works some what natural for you |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
- Coverage 93.72% 92.41% -1.32%
==========================================
Files 24 25 +1
Lines 1801 1859 +58
==========================================
+ Hits 1688 1718 +30
- Misses 113 141 +28 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
update from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation for local data reading is quite flexible to for example make it possible to also read daily data. It is mostly controlled through a glue formatting string as documented (please check if you understand).
Currently if no file is found the function fails. If some data is found it warns about the data not found. However it could be whole radars are absent and thus not read with only a warning