docs(adr-031): Phase E land — ADR-031 本採用昇格 + handoff doc retire + 2026-06-01 dogfood 採用 3 件#192
Open
aloekun wants to merge 1 commit into
Open
docs(adr-031): Phase E land — ADR-031 本採用昇格 + handoff doc retire + 2026-06-01 dogfood 採用 3 件#192aloekun wants to merge 1 commit into
aloekun wants to merge 1 commit into
Conversation
…26-06-01 dogfood 採用 3 件 ## 採用判定 (ADR-031 試験運用 → 承認済み) Phase D (2026-05-30) + Phase E (2026-06-01) 計 2 回の dogfood で計 18 findings / 採用 8 件 / 却下 8 件 / 保留 2 件を観測。wall-clock (約 5 分以内) / context window 圧迫なし / finding 品質 (採用率 44%、false positive なし) / systemic finding 検出力 (cross-PR drift / dead-pointer / partial overlap を実検出) など、scope 軸の空白埋めとして機能を確認。本採用化判定済。 ## Phase E dogfood (2026-06-01) 採用 3 件 + 保留 2 件 + 却下 1 件 - WR-2026-06-01-S01 (High, simplicity): subprocess utils 4-5 crate 横断重複 → 既存 todo9.md combine_output extract entry に augment (scope 拡大、lib-subprocess-utils へ命名変更) - WR-2026-06-01-C02 (Medium, security): cli-merge-pipeline/feedback.rs の owner_repo 検証非対称 → docs/todo.md 「週次レビュー採用 (2026-06-01)」に新規追加 - WR-2026-06-01-A01 (Medium, architecture): CLAUDE.md ADR-032 dead-pointer (4 箇所) → docs/todo.md に新規追加 - 保留: WR-2026-06-01-S02 (hook バイナリ 800 行超過) + WR-2026-06-01-C01 (PR_MONITOR_STATE_FILE_OVERRIDE) - 却下: WR-2026-06-01-C03 (env var override 監査ログ、ADR-039 設計通り) ## handoff doc retire (Cross-File Reference Lifecycle 適合) docs/handoff-weekly-review-phase-c-onwards.md を物理削除。永続価値は ADR-031 § 採用判定の根拠 に migrate 済 (dogfood 観測メトリクス + 本採用判断根拠)。残存参照は ADR-031 内 1 箇所のみ (path-free な過去形記述に書き換え済)。 ## todo.md / todo-summary.md cross-ref 清掃 - todo-summary.md 順位 8 (週次レビュー Phase B) 削除 - todo-summary.md 順位 21/38/153/154 の「順位 8」参照を ADR-031 (本採用 2026-06-01) 参照に置換 - todo.md ADR-031 entry (200 行) 削除 (feedback_todo_no_history.md 適用) - todo9.md 153/154 entry の「順位 8 follow-up」を「ADR-031 weekly-review 拡張」に置換 - todo4.md L3 weekly mutants entry の Phase B 依存記述を本採用後の独立着手記述に更新 ## ADR-039 retirement workflow 採用経路 = 試験運用 → 本採用 (ADR status update のみで十分、新規 ADR 不要)。config opt-in (`WeeklyReviewReminderConfig::enabled`) / kill-switch (revert path) / bounded lifetime (dogfood 採用条件) の 3 点セットは本採用後も guard として維持。
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
💤 Files with no reviewable changes (1)
📝 Walkthrough概要ADR-031 週次レビューパイプラインが 2026-06-01 に本採用承認され、Phase E dogfood の観測結果と判定がドキュメントに記録されました。同時にハンドオフドキュメントが削除され、関連タスク実行順序と今後の拡張計画が再整理されました。 変更内容ADR-031 本採用と後続計画
評価🎯 2 (Simple) | ⏱️ ~12 分 関連する可能性のある PR
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
ADR-031 (週次プロジェクト全体レビューパイプライン) Phase E land — 試験運用 → 承認済みへ昇格。Phase D + Phase E の 2 回 dogfood で本採用条件を充足したため本採用化、handoff doc retire、関連 todo entry close。
Phase E dogfood (2026-06-01) 結果
Phase E 採用 findings (3 件)
combine_outputextract entry に augment (scope 拡大、lib-subprocess-utils へ命名変更)cli-merge-pipeline/feedback.rsのowner_repo検証非対称 (defense-in-depth 欠如) → docs/todo.md 「週次レビュー採用 (2026-06-01)」に新規追加Phase E 保留 + 却下
ADR-031 本採用化 + ADR-039 retirement workflow
試験運用 (2026-04-27)→承認済み (2026-06-01)### 採用判定の根拠 (Phase E dogfood 観測結果)section を追加 (観測メトリクス表 + 判定根拠)handoff doc retire (docs-governance § Retirement Workflow 4 step 適合)
docs/handoff-weekly-review-phase-c-onwards.md(157 行) 物理削除todo / cross-ref cleanup
feedback_todo_no_history.md運用ルール (完了タスクは ADR/仕組みに反映後 todo.md から削除) を実適用pre-push pipeline
Test plan
grep -rn 'handoff-weekly-review-phase-c-onwards'0 件確認済)関連
Summary by CodeRabbit
リリースノート