feat: support for versioning Dither protocol implementations #494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dither-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jeronimoalbi
changed the title
jeronimoalbi
changed the title
Member
Author
|
cc @Kouteki |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dither protocol is open, it uses a memo field and a send message, so anyone can "pollute" Dither namespace sending multiple transactions using different non existent function names, which might be expected to be supported in the future. Apart from polluting the namespace they could also generate issues when replaying historical transactions to restore the data.
Versioning dither protocol implementation makes the protocol safer.
Versions are defined by the address of the destination account used in the send messages.
New versions must be created when the protocol changes because new functions are added, or because existing function parameters change. A new version means that the destination account for the send transactions must be changed to a different one.