fix: pass GITHUB_TOKEN to checkout in node-pr workflow#121
Closed
fix: pass GITHUB_TOKEN to checkout in node-pr workflow#121
Conversation
Explicitly passing the GITHUB_TOKEN to the checkout action ensures that it has the necessary permissions for subsequent git operations, such as fetching the full history when persist-credentials is set to false.
hubertott
requested review from
AdamJHall,
NgaNaNa,
TheOrangePuff and
aaronmedina-dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the proposed changes
Both "Fetch all commits for Nx" steps in the build and test jobs now have
token: ${{ secrets.GITHUB_TOKEN }}. This provides authentication for the full-history fetch whilepersist-credentials: falsestill ensures the token isn't left in the git config after the step completes.Screenshots (if applicable)
External Organisation Error Example
Other solutions considered (if any)
Notes to PR author
Notes to reviewers
Only edge case:
a caller that explicitly sets permissions: {} (stripping all token scopes) — but that would already break the initial actions/checkout step at the top of the job, so it's not a new regression from this change.
ℹ️ When you've finished leaving feedback, please add a final comment to the PR tagging the author, letting them know that you have finished leaving feedback