catch error when we get from the network less data than we expect#76
Open
AoJ wants to merge 1 commit intoalibaba:masterfrom
Open
catch error when we get from the network less data than we expect#76AoJ wants to merge 1 commit intoalibaba:masterfrom
AoJ wants to merge 1 commit intoalibaba:masterfrom
Conversation
Member
|
Can also add tests for this? |
Member
|
Can add test case for this change? |
Author
|
Sorry for the delay. I'll look at it during the week. |
Member
|
ping @AoJ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On failure of the network we may come less data than we expect. When we are reading more bytes from the buffer may raise uncaught exception. This commit is converted an exception to error event.