Fix message list handling for multiple tool results#449
Open
Ledraw wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue in
fix_message_list()where valid multi-tool-call sequences could be treated as invalid and repeatedly reordered.When one assistant message contains multiple
tool_calls, the valid message sequence is:The previous logic only considered a tool message valid if the immediately preceding message was an assistant message with the matching tool_call_id. That works for the first tool result, but incorrectly marks the second and third tool
results as invalid because their previous message is another tool result.
This could cause the tool messages to be repeatedly moved after the assistant message and lead to a non-terminating reorder loop.
Changes
Test
./cai/.venv/bin/python -m pytest tests/cli/test_cli_streaming.py -k "fix_message_list" -q