Added the temperature parameter of e O‑series models#164
Open
Ethan-han921 wants to merge 3 commits intoalgorithmicsuperintelligence:mainfrom
Open
Added the temperature parameter of e O‑series models#164Ethan-han921 wants to merge 3 commits intoalgorithmicsuperintelligence:mainfrom
Ethan-han921 wants to merge 3 commits intoalgorithmicsuperintelligence:mainfrom
Conversation
This pull request fixes an issue in the OpenAILLM class where O‑series models (e.g., o3-mini, o4-mini) should not receive a temperature parameter. Previously, temperature was always included in the API call parameters without any warnings or errors. I have now corrected this behavior and added a unit test named test_openai_model.py.
|
|
Ethan-han921
changed the title
codelion
reviewed
Aug 8, 2025
| import asyncio | ||
|
|
||
| try: | ||
| asyncio.get_running_loop() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue in the OpenAILLM class where O‑series models (e.g., o3-mini, o4-mini) should not receive a temperature parameter. Previously, temperature was always included in the API call parameters without any warnings or errors. Now it has been solved and added to a unit test named test_openai_model.py.