-
Notifications
You must be signed in to change notification settings - Fork 59
Reimplemetation of macro engine #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: osur
Are you sure you want to change the base?
Conversation
| "name": "all off", | ||
| "defaultDelay": 20, | ||
| "sequence": [ | ||
| [ "call", "lights off"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that if this was called macro it would be more intuitive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since the sequence is just a property of the macro, but not the macro itself, it would lead to less intuitive expressions on the code side. Although I see your point, I'd suggest to keep it.
| "lirc_web": "./app.js" | ||
| }, | ||
| "config": { | ||
| "test_env": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be set to false by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as far as I have understood, this is applied only on calls of the script section. There we only have test calls and this default is exactly what we need.
|
Sorry for the delay. I took some time today and read through this. I appreciate how you refactored the macro engine, I do think this is a cleaner separation than how it was before. I also believe this could be a good step towards supporting additional communication protocols ( I'll attempt to run this on my raspberryPi, updating my Thanks! |
open: automatic resolving of virtual state dependency e.g. user triggers "Watch Bluray", blu-ray needs projector on, projector on needs lowered screen.