Fix for AlexaResponse.js failing on line 58:62#13
Open
MaltronCraft wants to merge 2 commits into
Open
Conversation
Fixed an issue where uuid module would not work. Replaced uuid with uuid-random.
|
@MaltronCraft thanks for submitting this PR! Looks good to me. @YiddishNinja what are your thoughts? |
Aymkdn
reviewed
Dec 6, 2020
| 'use strict'; | ||
|
|
||
| let uuid = require('uuid'); | ||
| let uuid = require('uuid-change'); |
There was a problem hiding this comment.
It should be:
let uuid = require('uuid-random');
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues:
When running directiveDiscovery test on lambda, AlexaResponse.js would fail with the following error:
Response: { "errorType": "TypeError", "errorMessage": "uuid is not a function", "trace": [ "TypeError: uuid is not a function", " at new AlexaResponse (/var/task/alexa/skills/smarthome/AlexaResponse.js:58:62)", " at Runtime.exports.handler (/var/task/index.js:67:19)", " at Runtime.handleOnce (/var/runtime/Runtime.js:66:25)" ] }Description of changes:
In AlexaResponse I changed line 16
let uuid = require('uuid');tolet uuid = require('uuid-random');In packages.json I changed line 14
"uuid": ">1.0.0"to"uuid-random": ">1.8.0"By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.