Feature: filter crn can with based on vm resources #268
+116
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1yam
force-pushed
the
1yam-better-filter-crn
branch
from
5f94591 to
a6861a6
Compare
odesenfans
reviewed
Jan 5, 2026
Contributor
odesenfans
left a comment
odesenfans
left a comment
There was a problem hiding this comment.
Minor comments, looks okay besides that.
1yam
force-pushed
the
1yam-better-filter-crn
branch
from
8c17a59 to
2a5daff
Compare
…nstead of regular int
… it's cant be negative
1yam
force-pushed
the
1yam-better-filter-crn
branch
from
2a5daff to
a57000e
Compare
odesenfans
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
Related ClickUp, GitHub or Jira tickets : ALEPH-
Self proofreading checklist
Changes
This pull request enhances the filtering capabilities of the CRN (Compute Resource Node) service by allowing users to filter nodes based on specific VM resource requirements (CPU, memory, disk). To support this, new data models for system usage and VM resources have been introduced, and the filtering logic has been updated accordingly.
Filtering and API Enhancements
VmResourcesmodel to specify VM requirements (vCPUs, memory in MiB, disk in MiB), and updated thefilter_crnmethod to accept this as an optional parameter. The method now filters nodes based on available resources, ensuring that only nodes meeting the specified criteria are returned. [1] [2] [3] [4]Data Model Additions
CpuLoad,CoreFrequencies,CpuInfo,MemoryInfo,DiskInfo,UsagePeriod,SystemUsage) to represent detailed system usage statistics for CRNs. These are now included in theCRNmodel as an optionalsystem_usagefield, enabling resource-based filtering. [1] [2] [3]