Upgrade 4.1.3#35
Conversation
feat: added command to update the permission for activeredis
Co-authored-by: idp-bot <idp-bot@alauda.io>
…-4.1 Auto-update doc build config
* backup * feat: added redis best practices * Update docs/en/how_to/redis-best-practices.mdx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update docs/en/how_to/redis-best-practices.mdx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update docs/en/how_to/redis-best-practices.mdx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: fix affinity label error * Update docs/en/how_to/redis-best-practices.mdx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…-4.1 Auto-update doc build config
* backup * feat: added redis best practices * Update docs/en/how_to/redis-best-practices.mdx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update docs/en/how_to/redis-best-practices.mdx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update docs/en/how_to/redis-best-practices.mdx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: fix affinity label error * Update docs/en/how_to/redis-best-practices.mdx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * fix: fix lint * fix: updated the references * chore: trigger pipeline * docs: rename title --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* feat: added release notes for 4.1.2 * fix: updated filter
* fix: fix example code bug * fix: removed quote from port placeholder
|
Caution Review failedPull request was closed or merged during review WalkthroughRedis documentation updated with operational guides, build pipeline restructuring, and release notes. Disaster recovery and upgrade documentation reorganized with heading restructuring. Build pipelines split into separate IO and CN variant tasks. Development dependencies updated to Yarn 4.9.4 and Doom 1.12.1. New Tekton PipelineRun manifests added for documentation builds. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates the Redis OSS product docs/tooling to align with ACP 4.1.x (and the v4.1.3 release notes flow), including dependency/toolchain upgrades and new/expanded English documentation.
Changes:
- Upgraded the docs build toolchain (Yarn +
@alauda/doom) and refreshedyarn.lock. - Added/updated release notes + upgrade documentation and introduced additional “best practices” guidance.
- Added Tekton PipelineRun definitions for doc builds and adjusted build task resource overrides.
Reviewed changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
yarn.lock |
Dependency lock refresh for the upgraded toolchain. |
package.json |
Bumps @alauda/doom and Yarn package manager version. |
.yarnrc.yml |
Points repo to Yarn 4.9.4 release artifact. |
sites.yaml |
Updates ACP site version from 4.0 to 4.1. |
doom.config.yml |
Adds/adjusts release notes query templates for 4.1.x streams. |
docs/en/upgrade.mdx |
Rewrites upgrade guidance and adds operator upgrade steps. |
docs/en/release_notes.mdx |
Adds v4.1.1–v4.1.3 sections and updates compatibility matrix. |
docs/en/how_to/best-practices.mdx |
New best-practices guide content. |
docs/en/how_to/access/10-sentinel.mdx |
Updates client examples/placeholders. |
docs/en/how_to/access/20-cluster.mdx |
Updates client examples/placeholders, incl. Jedis cluster sample. |
docs/en/how_to/30-upgrade.mdx |
Expands patch-upgrade instructions (adds CLI tabs). |
docs/en/functions/95-disaster-recovery/* |
Heading/structure edits + added ACP 4.1.0 permission note. |
.tekton/doc-pr-build.yaml |
New PR doc build PipelineRun definition. |
.tekton/doc-build.yaml |
New push doc build PipelineRun definition. |
.builds/doc-build.yaml |
Updates build task names and per-task build resources. |
.cspell/compound.txt |
Adds oplog to spelling dictionary. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| $ kubectl -n redis-system get subscriptions.operators.coreos.com redis-operator -o jsonpath='{.status.installplan.name}' | ||
|
|
||
| # Approve the InstallPlan to proceed with the upgrade | ||
| $ kubectl -n redis-system patch --type='json' -p='[{"op":"replace","path":"/spec/approved","value":true}]' |
There was a problem hiding this comment.
In the CLI steps for manual operator upgrades, the command to approve an InstallPlan is missing the resource kind/name. kubectl patch requires a target (e.g., installplan <name>); as written, the command will fail even if the user has already fetched .status.installplan.name. Please update the command to patch the specific InstallPlan returned in the previous step.
| $ kubectl -n redis-system patch --type='json' -p='[{"op":"replace","path":"/spec/approved","value":true}]' | |
| $ kubectl -n redis-system patch installplan $(kubectl -n redis-system get subscriptions.operators.coreos.com redis-operator -o jsonpath='{.status.installplan.name}') --type='json' -p='[{"op":"replace","path":"/spec/approved","value":true}]' |
| | Alauda Cache Service for Redis OSS Version | Redis Server Versions | ACP Version | | ||
| |:-------------------------------------------|:---------------------------|:------------| | ||
| | v4.1.2 | 5.0.15, 6.0.21, 7.2.12 | v4.1, v4.2 | | ||
| | v4.1.1 | 5.0.15, 6.0.21, 7.2.12 | v4.1 | | ||
| | v4.1.0 | 5.0.14, 6.0.20, 7.2.10 | v4.1 | | ||
| | v4.0.x | 5.0.14, 6.0.20, 7.2.x | v4.0 | |
There was a problem hiding this comment.
The supported upgrade-path matrix doesn’t include v4.1.3, but this PR is introducing v4.1.3 release notes and query templates. To keep the upgrade guidance in sync with the newly documented release, please add a v4.1.3 row (or otherwise clarify why it’s intentionally omitted).
| @@ -1,69 +1,87 @@ | |||
| --- | |||
There was a problem hiding this comment.
This file’s frontmatter previously defined title and an i18n.title.zh value (matching other top-level docs like architecture.mdx, installation.mdx, etc.). Removing those fields may degrade sidebar/nav labeling and multilingual title rendering. If this page is still meant to be part of the main navigation, consider restoring title and i18n metadata for consistency.
| --- | |
| --- | |
| title: Upgrade | |
| i18n: | |
| title: | |
| zh: 升级 |
| --- | ||
| weight: 11 |
There was a problem hiding this comment.
This file’s frontmatter previously defined title and an i18n.title.zh value (matching other top-level docs like architecture.mdx, installation.mdx, etc.). Removing those fields may degrade sidebar/nav labeling and multilingual title rendering. If this page is still meant to be part of the main navigation, consider restoring title and i18n metadata for consistency.
| --- | |
| weight: 11 | |
| --- | |
| title: Release Notes | |
| weight: 11 | |
| i18n: | |
| title: | |
| zh: 发行说明 |
| mw-redis-v4.1-fixed: | | ||
| filter = project = MiddleWare AND type = Bug AND ReleaseNotesStatus = Publish AND Feature in ("MiddleWare - Redis") AND fixVersion = Redis-v4.1.0 | ||
| project = MiddleWare AND type = Bug AND ReleaseNotesStatus = Publish AND Feature in ("MiddleWare - Redis") AND fixVersion = Redis-v4.1.0 | ||
| mw-redis-v4.1-known: | | ||
| filter = project = MiddleWare AND type = Bug AND ReleaseNotesStatus = Publish AND Feature = "MiddleWare - Redis" AND affectedVersion in (Redis-v4.1.0) AND fixVersion is EMPTY | ||
| project = MiddleWare AND type = Bug AND ReleaseNotesStatus = Publish AND Feature = "MiddleWare - Redis" AND affectedVersion in (Redis-v4.1.0) AND fixVersion is EMPTY | ||
| mw-redis-v4.1.1-fixed: | | ||
| project = MiddleWare AND type in (Bug, Vulnerability) AND ReleaseNotesStatus = Publish AND fixVersion = Redis-v4.1.1 | ||
| mw-redis-v4.1.2-fixed: | | ||
| status in (Done, Resolved) AND (labels not in (安全问题) OR labels is EMPTY) AND project = MIDDLEWARE AND Feature = "MiddleWare - Redis" AND fixVersion = Redis-v4.1.2 AND ReleaseNotesStatus = Publish | ||
| mw-redis-v4.1.3-fixed: | | ||
| status in (Done, Resolved) AND (labels not in (安全问题) OR labels is EMPTY) AND project = MIDDLEWARE AND Feature = "MiddleWare - Redis" AND fixVersion = Redis-v4.1.3 AND ReleaseNotesStatus = Publish |
There was a problem hiding this comment.
The new query templates under releaseNotes.queryTemplates (v4.1.0+ / v4.1.1+ / v4.1.2+ / v4.1.3+) no longer start with filter =, while the existing v4.0 templates do. If the release-notes generator expects the filter = ... form (as used in the other templates in this file), these templates will be parsed differently and may cause the release-notes-for-bugs blocks to fail to resolve. Please make the template format consistent (either add filter = back or update all templates to the new expected syntax).
Summary by CodeRabbit
Documentation
Chores