Skip to content

fix: support containerd v2 sandbox config and ignore pause image pull…#44

Open
jiazhiguang wants to merge 1 commit intomasterfrom
fix/containerd-sandbox-compat
Open

fix: support containerd v2 sandbox config and ignore pause image pull…#44
jiazhiguang wants to merge 1 commit intomasterfrom
fix/containerd-sandbox-compat

Conversation

@jiazhiguang
Copy link
Copy Markdown

@jiazhiguang jiazhiguang commented Apr 11, 2026

… errors

Containerd v2 renamed sandbox_image to sandbox in its config. The sed command now replaces both keys so the pause image is set correctly regardless of the containerd version. Also adds ignorePreflightErrors: [ImagePull] to init/join nodeRegistration so kubeadm does not fail when the built-in pause tag differs from the registry.

Summary by CodeRabbit

  • Documentation
    • Updated VMware vSphere cluster bootstrap configuration guidance for control-plane and worker nodes, including enhanced containerd sandbox settings and kubelet preflight error handling.

… errors

Containerd v2 renamed `sandbox_image` to `sandbox` in its config. The
sed command now replaces both keys so the pause image is set correctly
regardless of the containerd version. Also adds `ignorePreflightErrors:
[ImagePull]` to init/join nodeRegistration so kubeadm does not fail when
the built-in pause tag differs from the registry.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5d566a3d-e644-4eae-a998-12c52df86e11

📥 Commits

Reviewing files that changed from the base of the PR and between abf20c8 and afc8292.

📒 Files selected for processing (1)
  • docs/en/create-cluster/vmware-vsphere/create-cluster-in-global.mdx

Walkthrough

Documentation update for VMware vSphere cluster creation adds sandbox field configuration to containerd setup and introduces kubelet preflight error suppression for ImagePull in kubeadm bootstrap commands for both control-plane and worker node templates.

Changes

Cohort / File(s) Summary
Documentation
docs/en/create-cluster/vmware-vsphere/create-cluster-in-global.mdx
Updated bootstrap commands to set sandbox field in containerd config.toml alongside sandbox_image, and added ignorePreflightErrors: [ImagePull] to kubeadm nodeRegistration configurations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 With whiskers twitching at each config line,
I hop through docs to make containerd shine,
Sandboxes nested, preflight errors blessed,
Clear instructions help clusters pass the test! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main changes: support for containerd v2's new sandbox config syntax and ignoring pause image pull errors.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/containerd-sandbox-compat

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

Deploying alauda-immutable-infra with  Cloudflare Pages  Cloudflare Pages

Latest commit: afc8292
Status: ✅  Deploy successful!
Preview URL: https://32e45f50.alauda-immutable-infra.pages.dev
Branch Preview URL: https://fix-containerd-sandbox-compa.alauda-immutable-infra.pages.dev

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant