Fix Chinese pinyin input issues in the editor#319
Open
FeodorFitsner wants to merge 2 commits intoakvelon:mainfrom
Open
Fix Chinese pinyin input issues in the editor#319FeodorFitsner wants to merge 2 commits intoakvelon:mainfrom
FeodorFitsner wants to merge 2 commits intoakvelon:mainfrom
Conversation
- preserve composing-only TextEditingValue updates - bypass editor transforms while IME composition is active - use Flutter composing-aware buildTextSpan during composition - clamp selections in Code.getEditResult for transient IME ranges - disable Enter/Tab/Esc shortcuts while composing - add regression tests for composing updates and IME commit
- handle old composing -> new non-composing transition as direct update - keep internal code state synced during composition updates - preserve stable IME behavior on macOS and web
nausharipov
reviewed
Apr 25, 2026
| _code = _createCode(text ?? ''); | ||
| fullText = text ?? ''; | ||
|
|
||
| debugPrint('CodeController initialized with text:\n$text'); |
Collaborator
There was a problem hiding this comment.
debugPrint('CodeController initialized with text:\n$text'); logs full editor content on every controller initialization. This can leak sensitive user code/data and create noisy logs for large documents. Please remove this log (or guard it behind an explicit opt-in debug flag that defaults off).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes Chinese pinyin input issues in the editor.
Fixes #126
Root causes:
Changes:
Tests: