Skip to content

Conversation

@troian
Copy link
Member

@troian troian commented Nov 24, 2025

No description provided.

Signed-off-by: Artur Troian <troian@users.noreply.github.com>
@troian troian requested a review from a team as a code owner November 24, 2025 14:31
@coderabbitai
Copy link

coderabbitai bot commented Nov 24, 2025

Walkthrough

This PR updates the Docker base image from Debian Bullseye to Ubuntu Noble, adds port exposure directives for the Akash node, and changes the default snapshot source for test upgrades from mainnet to sandbox-2.

Changes

Cohort / File(s) Summary
Docker Configuration
_build/Dockerfile.akash
Base image updated from debian:bullseye to ubuntu:noble; new EXPOSE directive added for ports 26656, 26657, and 26658.
Build Configuration
make/test-upgrade.mk
Default value of SNAPSHOT_SOURCE parameter changed from mainnet to sandbox-2, altering the default test upgrade code path.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

These are straightforward configuration updates with no logic modifications or functional complexity. The Docker base image change and EXPOSE additions are low-risk, and the snapshot source default adjustment is a simple parameter modification.

Poem

🐰 To Ubuntu Noble our Docker now flies,
Port 26656 beneath the network skies,
And sandbox-2 becomes our testing friend,
Build configs refresh, the updates blend!

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to evaluate relevance to the changeset. Add a description explaining the rationale for bumping the base image to ubuntu:noble and any impact or benefits of this change.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title directly describes the main change in the Dockerfile - bumping the base image from debian:bullseye to ubuntu:noble, which is the primary modification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bump-image

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 009fab0 and 596cda0.

📒 Files selected for processing (2)
  • _build/Dockerfile.akash (1 hunks)
  • make/test-upgrade.mk (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: network-upgrade
  • GitHub Check: sims
  • GitHub Check: tests
  • GitHub Check: release-dry-run
  • GitHub Check: lint-go
  • GitHub Check: coverage
  • GitHub Check: build-bins
  • GitHub Check: build-macos
🔇 Additional comments (2)
_build/Dockerfile.akash (2)

6-6: LGTM! Standard Cosmos SDK ports exposed.

The exposed ports are standard for Tendermint/CometBFT-based chains:

  • 26656: P2P port
  • 26657: RPC port
  • 26658: Prometheus metrics port

1-1: ---

Ubuntu Noble image is valid; verify known compatibility issues apply to your deployment context.

The ubuntu:noble image exists and is actively maintained on Docker Hub (last updated 2025-11-15 with 12 architecture variants).

However, there are known Ubuntu 24.04 "Noble" Docker-image compatibility issues including signal delivery / abrupt container kills, containerd / runtime mismatches in some environments, and update-ca-certificates memory issues. These are environment-specific: mitigations include downgrading containerd.io to a known-working 1.7.x for certain systems, or using alternative runtimes like podman.

Verify whether these issues affect your Akash validator/node deployment by checking:

  • Container runtime versions in your target environment (especially containerd.io and Docker CE versions)
  • Whether graceful SIGTERM shutdown is required for your service
  • Any update-ca-certificates or signal-dependent operations in the Dockerfile

Comment @coderabbitai help to get the list of available commands and usage tips.

@troian troian merged commit 56645e3 into main Nov 24, 2025
18 checks passed
@troian troian deleted the bump-image branch November 24, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants