feat(provider): remove provider attribute edit form from deploy-web#3266
Merged
Conversation
The deploy-web provider edit page signed an on-chain MsgUpdateProvider to change attributes, which conflicts with helm/provider.yaml management and leaves no single source of truth. This functionality now belongs in the provider-console app, so deploy-web drops it. Removes the /providers/[owner]/edit route, its container/form components, the edit-only attribute helpers/data, the Edit button on the provider detail page, the providerDetailEdit URL helper, the now-orphaned getUpdateProviderMsg tx builder, and the form-only Zod schema. The read-only provider detail view (useProviderAttributesSchema) is untouched. Closes #194
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (10)
💤 Files with no reviewable changes (8)
📝 WalkthroughWalkthroughThis PR removes the provider attribute editing feature from Cloudmos Console: EditProviderContainer and EditProviderForm components, the ChangesProvider Attribute Editing Removal
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Assessment against linked issues
Suggested labels
Suggested reviewers
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed due to a network error. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3266 +/- ##
==========================================
- Coverage 67.29% 66.49% -0.81%
==========================================
Files 1083 992 -91
Lines 26500 24162 -2338
Branches 6380 5896 -484
==========================================
- Hits 17833 16066 -1767
+ Misses 7591 7071 -520
+ Partials 1076 1025 -51
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The deploy-web provider edit page (
/providers/[owner]/edit) signs an on-chainMsgUpdateProviderto change provider attributes. This conflicts with helm/provider.yaml-based provider management — when a provider re-runs helm, theprovider.yamlvalues overwrite whatever was set via the form, so there is no single source of truth. The new provider-console app is the right home for provider configuration, so deploy-web should simply drop this form.Closes #194
What
Pure removal of the deploy-web provider attribute edit form plus cleanup of the now-orphaned supporting code:
/providers/[owner]/editroute,EditProviderContainer,EditProviderForm, and the edit-only attribute helpers/data (utils/providerAttributes/{helpers,data}.ts).ProviderDetailLayout) and the now-unuseduseWallet/Link/buttonVariants/cnimports.providerDetailEditURL helper, the orphanedgetUpdateProviderMsgtx builder (+ itsMsgUpdateProviderimport), and the form-only Zod schema (providerAttributesFormValuesSchema) from deploy-web's types.getUpdateProviderMsgentry from the onboarding spec'sTransactionMessageDatamock.The read-only provider detail view is untouched —
useProviderAttributesSchemaand theProviderAttributesSchematype are kept since they still drive the detail display. provider-console's own copy of the attribute schema is unaffected.Verification: type-check clean for changed source files, lint clean, and the touched onboarding + providers test suites pass (34/34).
Summary by CodeRabbit