ImmersiveTravel compatibility #45
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ensured a cast in TravelOptionsMapWindow.ClickHandler() only happens if it's valid (aka if ImmersiveTravel hasn't overridden the DaggerfallTravelPopUp class) - ensured travel outside of location using the "allow targeting map coordinates" option still works if ImmersiveTravel is active
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two small changes to TravelOptions/Scripts/TravelOptionsMapWindow.cs to ensure better interactions between TravelOptions and my own fast-travel related mod, ImmersiveTravel (https://github.com/kkgobkk/immersive-travel)
ensured a cast in TravelOptionsMapWindow.ClickHandler() only happens if it's valid (aka if ImmersiveTravel hasn't overridden the DaggerfallTravelPopUp class). Without this change, the map breaks after the TravelPopUp window from ImmersiveTravel is displayed the first time.
ensured travel outside of location using the "allow targeting map coordinates" option still works if ImmersiveTravel is active
note: i haven't changed the mod version in TravelOptions/TravelOptions.dfmod.json