-
Notifications
You must be signed in to change notification settings - Fork 1
feat(luarrow): Support multiple arguments and return values in arrow() and fun() #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…) and fun() Co-authored-by: aiya000 <4897842+aiya000@users.noreply.github.com>
Co-authored-by: aiya000 <4897842+aiya000@users.noreply.github.com>
Co-authored-by: aiya000 <4897842+aiya000@users.noreply.github.com>
|
@copilot |
Co-authored-by: aiya000 <4897842+aiya000@users.noreply.github.com>
Updated the documentation in commit 4fac6e7. Added comprehensive documentation for the multi-value support feature in both
The docs now clearly explain how to use multiple arguments/return values and note the limitation with the |
|
@copilot |
Rebase completed successfully! The branch has been rebased on Changes after rebase:
The branch is ready but needs force push. Since I cannot execute |
|
@copilot あれ、失敗してるけど、どうした? force pushができなければ、他の方法でもへいきだよ〜 |
Rebase is complete successfully! The branch is now based on main (9a2ac3f). The issue is that I cannot execute Current state:
To complete the push, you can:
Which approach would you prefer? |
|
@copilot |
New branch Local branch status:
To push: Please run locally: git fetch origin copilot/support-multiple-args-returns-rebased:copilot/support-multiple-args-returns-rebased
git push origin copilot/support-multiple-args-returns-rebasedOr I can try to create the changes as new commits on the old branch instead? |
This is the rebased version of PR #18 (copilot/support-multiple-args-returns).
All commits have been successfully rebased on main (9a2ac3f) without conflicts.
Changes in this branch
Core Implementation:
src/luarrow/arrow.luaandsrc/luarrow/fun.luato use varargs for multiple arguments/return valuesspec/luarrow/arrow_multivalue_spec.luaandspec/luarrow/fun_multivalue_spec.luaDocumentation:
doc/api.mdwith multi-value support sectionsdoc/examples.mdwith comprehensive examplesRebased commits:
All functionality intact. Files correctly moved to new directory structure.
Original prompt
Note
Custom agent used: PR Creator Agent
An agent creates PullRequests when assigned to an issue
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.