Confirm Label_SQ is the only decoder with non-number version string; fix it#367
Closed
Copilot wants to merge 1 commit intoclaude/improve-library-architecture-6SsF3from
Closed
Confirm Label_SQ is the only decoder with non-number version string; fix it#367Copilot wants to merge 1 commit intoclaude/improve-library-architecture-6SsF3from
Copilot wants to merge 1 commit intoclaude/improve-library-architecture-6SsF3from
Conversation
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on MessageDecoder refactor regarding non-number strings
Confirm Label_SQ is the only decoder with non-number version string; fix it
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RawFields.versionis typed asnumber, butLabel_SQwas assigning it directly fromString.prototype.substring, producing a string and comparing with=== '2'. Investigation confirmed this was the only decoder with this inconsistency — all others setraw.versionviaResultFormatter.version(), which stores anumber.Changes
Label_SQ: Wrap substring extraction withNumber()and update comparison from=== '2'to=== 2; convert to string only at the display layer (String(decodeResult.raw.version))🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.