Skip to content

fix: improve ERROR_READING_FILE message and raise AirbyteTracedException with system_error #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
devin-ai-integration wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix: improve ERROR_READING_FILE message and raise AirbyteTracedException with system_error #955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31119b7
fix: improve ERROR_READING_FILE message and raise AirbyteTracedExcept…
devin-ai-integration[bot] Mar 20, 2026
6d6ca32
fix: revert test scenarios to expect None since AirbyteTracedExceptio…
devin-ai-integration[bot] Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ..._cdk/sources/file_based/availability_strategy/default_file_based_availability_strategy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
from typing import TYPE_CHECKING, Optional, Tuple

from airbyte_cdk import AirbyteTracedException
from airbyte_cdk.models import FailureType
from airbyte_cdk.sources import Source
from airbyte_cdk.sources.file_based.availability_strategy import (
AbstractFileBasedAvailabilityStrategy,
Expand Down Expand Up @@ -133,8 +134,10 @@ def _check_parse_record(
except AirbyteTracedException as ate:
raise ate
except Exception as exc:
raise CheckAvailabilityError(
FileBasedSourceError.ERROR_READING_FILE, stream=stream.name, file=file.uri
raise AirbyteTracedException(
message=FileBasedSourceError.ERROR_READING_FILE.value,
internal_message=f"Error reading file {file.uri} in stream {stream.name}: {exc}",
failure_type=FailureType.system_error,
) from exc

schema = stream.catalog_schema or stream.config.input_schema
Expand Down
2 changes: 1 addition & 1 deletion airbyte_cdk/sources/file_based/exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class FileBasedSourceError(Enum):
ERROR_CASTING_VALUE_UNRECOGNIZED_TYPE = "Could not cast the value to the expected type because the type is not recognized. Valid types are null, array, boolean, integer, number, object, and string."
ERROR_DECODING_VALUE = "Expected a JSON-decodeable value but could not decode record."
ERROR_LISTING_FILES = "Error listing files. Please check the credentials provided in the config and verify that they provide permission to list files."
ERROR_READING_FILE = "Error opening file. Please check the credentials provided in the config and verify that they provide permission to read files."
ERROR_READING_FILE = "File read failed during availability check."
ERROR_PARSING_RECORD = "Error parsing record. This could be due to a mismatch between the config's file type and the actual file type, or because the file or record is not parseable."
ERROR_PARSING_USER_PROVIDED_SCHEMA = (
"The provided schema could not be transformed into valid JSON Schema."
Expand Down
Loading