-
Notifications
You must be signed in to change notification settings - Fork 40
feat: add stderr heartbeat to diagnose stdout pipe blocking #953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
devin-ai-integration
wants to merge
12
commits into
main
Choose a base branch
from
devin/1773412868-nonblocking-stdout
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
ef5d8f6
feat: non-blocking stdout writes to prevent deadlock on pipe backpres…
devin-ai-integration[bot] 0e32124
fix: handle UnsupportedOperation from fileno() in test environments a…
devin-ai-integration[bot] e676457
fix: use sys.__stdout__ to get real fd when PRINT_BUFFER replaces sys…
devin-ai-integration[bot] 1b95a87
fix: fall back to print() when sys.stdout is replaced (capsys/PRINT_B…
devin-ai-integration[bot] 4d2c36f
fix: detect capsys/redirected stdout via fileno comparison, remove PR…
devin-ai-integration[bot] 649e0e0
fix: use dedicated writer thread instead of non-blocking fd to avoid …
devin-ai-integration[bot] 583e6ee
fix: catch Exception instead of BaseException in writer thread, re-ra…
devin-ai-integration[bot] b6f3f36
feat: add diagnostic logging to stdout writer thread to track pipe wr…
devin-ai-integration[bot] 75bd890
feat: add stderr heartbeat thread to prove platform never resumes rea…
devin-ai-integration[bot] 2fc96fa
refactor: simplify to heartbeat-only diagnostic (remove writer thread…
devin-ai-integration[bot] 17b4a6f
style: fix ruff formatting
devin-ai-integration[bot] 3a41aaa
style: add explanatory comment to empty except clause
devin-ai-integration[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.