Skip to content

feat: make concurrent CDK record queue unlimited to prevent deadlock #951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
devin-ai-integration wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

feat: make concurrent CDK record queue unlimited to prevent deadlock #951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a13be8a
feat: increase DEFAULT_MAX_QUEUE_SIZE from 10,000 to 50,000
devin-ai-integration[bot] Mar 12, 2026
9d70362
feat: make record queue unlimited (maxsize=0) to prevent deadlock
devin-ai-integration[bot] Mar 12, 2026
cb93ee4
fix: restore DEFAULT_MAX_QUEUE_SIZE to 10_000 for max_concurrent_task…
devin-ai-integration[bot] Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte_cdk/sources/concurrent_source/concurrent_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def __init__(
# threads generating partitions that than are max number of workers. If it weren't the case, we could have threads only generating
# partitions which would fill the queue. This number is arbitrarily set to 10_000 but will probably need to be changed given more
# information and might even need to be configurable depending on the source
self._queue = queue or Queue(maxsize=10_000)
self._queue = queue or Queue(maxsize=0)

def read(
self,
Expand Down
2 changes: 1 addition & 1 deletion airbyte_cdk/sources/declarative/concurrent_declarative_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ def __init__(
# threads generating partitions that than are max number of workers. If it weren't the case, we could have threads only generating
# partitions which would fill the queue. This number is arbitrarily set to 10_000 but will probably need to be changed given more
# information and might even need to be configurable depending on the source
queue: Queue[QueueItem] = Queue(maxsize=10_000)
queue: Queue[QueueItem] = Queue(maxsize=0)
message_repository = InMemoryMessageRepository(
Level.DEBUG if emit_connector_builder_messages else Level.INFO
)
Expand Down
Loading