Skip to content

chore: increase MAX_CONNECTION_POOL_SIZE from 20 to 40 #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Anatolii Yatsuk (tolik0) merged 3 commits into from
Apr 21, 2026
Merged

chore: increase MAX_CONNECTION_POOL_SIZE from 20 to 40 #926

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13b692c
chore: increase MAX_CONNECTION_POOL_SIZE from 20 to 40
devin-ai-integration[bot] Mar 2, 2026
82999a7
Merge branch 'main' into devin/1772449759-increase-max-connection-poo…
tolik0 Apr 6, 2026
bdc6622
Merge remote-tracking branch 'origin/main' into devin/1772449759-incr…
devin-ai-integration[bot] Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion airbyte_cdk/sources/http_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@
# order to fix that, we will increase the requests library pool_maxsize. As there are many pieces of code that sets a requests.Session, we
# are creating this variable here so that a change in one affects the other. This can be removed once we merge how we do HTTP requests in
# one piece of code or once we make connection pool size configurable for each piece of code
MAX_CONNECTION_POOL_SIZE = 20
MAX_CONNECTION_POOL_SIZE = 40
2 changes: 1 addition & 1 deletion unit_tests/sources/streams/http/test_http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,7 +837,7 @@ def test_duplicate_request_params_are_deduped(deduplicate_query_params, path, pa

def test_connection_pool():
stream = StubBasicReadHttpStream(authenticator=TokenAuthenticator("test-token"))
assert stream._http_client._session.adapters["https://"]._pool_connections == 20
assert stream._http_client._session.adapters["https://"]._pool_connections == 40
Comment thread
tolik0 marked this conversation as resolved.


class StubParentHttpStream(HttpStream, CheckpointMixin):
Expand Down
2 changes: 1 addition & 1 deletion unit_tests/sources/streams/http/test_http_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ def test_connection_pool():
http_client = HttpClient(
name="test", logger=MagicMock(), authenticator=TokenAuthenticator("test-token")
)
assert http_client._session.adapters["https://"]._pool_connections == 20
assert http_client._session.adapters["https://"]._pool_connections == 40


def test_valid_basic_send_request(mocker):
Expand Down
Loading