Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Voice Activity Detection (VAD) parameters in the speech-to-text client. The implementation allows users to configure VAD settings such as threshold, minimum speech duration, minimum silence duration, and maximum segment duration for both streaming and file transcription operations.
- Adds VadConfig dataclass with optional VAD parameters
- Integrates vad_config parameter into both sync and async transcribe_file and stream methods
- Includes comprehensive test coverage for VAD configuration scenarios
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| aiola/types.py | Defines VadConfig dataclass with threshold, min_speech_ms, min_silence_ms, and max_segment_ms fields |
| aiola/clients/stt/client.py | Adds vad_config parameter support to streaming and file transcription methods with validation |
| tests/unit/stt/test_stt_client.py | Comprehensive test coverage for VAD configuration in both sync and async operations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
yoavsraya
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




No description provided.