Skip to content

Fix HtmlDecoration attribute name for custom emoji method (#1782)#1783

Open
slav0nic wants to merge 1 commit intoaiogram:dev-3.xfrom
slav0nic:patch-1
Open

Fix HtmlDecoration attribute name for custom emoji method (#1782)#1783
slav0nic wants to merge 1 commit intoaiogram:dev-3.xfrom
slav0nic:patch-1

Conversation

@slav0nic
Copy link

@slav0nic slav0nic commented Mar 3, 2026

No description provided.

@github-actions github-actions bot added the 3.x Issue or PR for stable 3.x version label Mar 3, 2026
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

✔️ Changelog found.

Thank you for adding a description of the changes

@JrooTJunior
Copy link
Member

JrooTJunior commented Mar 3, 2026

Please update the tests and add changes description to the CHANGES/1782.bugfix.rst file.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the HTML custom emoji rendering to use the correct attribute name on the <tg-emoji> tag.

Changes:

  • Update HtmlDecoration.custom_emoji() to emit emoji-id instead of emoji_id.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@slav0nic
Copy link
Author

slav0nic commented Mar 4, 2026

done

@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (49eac31) to head (b95cafb).
⚠️ Report is 1 commits behind head on dev-3.x.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x     #1783   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          607       607           
  Lines        14425     14425           
=========================================
  Hits         14425     14425           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
aiogram/utils/text_decorations.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x Issue or PR for stable 3.x version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants