refactor: 関数ポインタ型のint引数をsize_t/int_fast16_tに修正#307
Merged
Conversation
- ConvertFunc系(pixelCount): int → size_t（バッファサイズの意味合い） - DDA系(count): int → int_fast16_t（ビューポート幅由来の座標寸法） - LineFilterFunc(count): int → int_fast16_t（スキャンライン幅由来） - 対応する実装関数・ローカル変数・ループカウンタも統一
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pixel_format.hで定義される関数ポインタ型のパラメータ型を、CODING_STYLE.md に従いintから適切な型に修正ConvertFunc系（ピクセル変換関数）:int pixelCount→size_t pixelCountCopyRowDDA_Func/CopyQuadDDA_Func（DDA転送関数）:int count→int_fast16_t countLineFilterFunc（ラインフィルタ関数）:int count→int_fast16_t count対象ファイル（12ファイル）
pixel_format.hdda.hrgba8_straight.hrgb565.hrgb888.hrgb332.halpha8.hgrayscale8.hindex.hformat_converter.hviewport.hfilters.hTest plan
./build.sh）— 成功./build.sh --debug）— 成功make all_tests && ./all_tests）— 160テスト、67718アサーション全パス