Add NBA mirror#30
Open
lyc61c wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new WebHarbor mirror site for NBA.com:
nba40015in the container, typically exposed ashttp://localhost:41015/during testingThe mirror implements an NBA.com-style sports information portal with homepage stories, games/schedule, playoffs, draft, fantasy, stats, standings, teams, players, news/articles, search, tickets, store/cart/checkout, and account flows. Runtime behavior is deterministic and uses SQLite plus local static assets only.
Seeded data
Major seeded model counts:
Functional coverage
Implemented routes and flows include:
Benchmark tasks
sites/nba/tasks.jsonlcontains 20 WebVoyager-schema benchmark tasks.Task coverage includes:
The tasks were revised to reduce benchmark leaks:
alice.j@test.com/TestPass123!task leakageTBD arenatask from an older schedule layoutPaired HuggingFace dataset PR
Paired asset-side PR:
<PASTE_HUGGINGFACE_DATASET_PR_LINK_HERE>
The HF asset bundle is
nba.tar.gzand contains:nba/instance_seed/nba.dbnba/static/images/nba/static/external_cache/After the HF PR merges, this code PR should bump
.assets-revisionto the merged dataset revision.Visual fidelity
The NBA mirror is designed to closely follow NBA.com rather than a generic Bootstrap demo:
static/images/; no runtime network fetchesScreenshot evidence to attach to this PR:
http://localhost:41015//schedule/draft/fantasy/playoffs/stats/standingsTest plan
python3 -m py_compile sites/nba/app.py./scripts/build.sh webharbor:devnbaalive on port40015//games/schedule/playoffs/draft/fantasy/stats/standings/teams/players/news/search/tickets/shop/loginPOST /reset/nbareturned"ready": trueReset evidence
Notes for reviewers
sites/nba/image/is a local scratch/reference directory and should not be included in the final GitHub PR.