Revert ABI breaking addition of assignments in C++#239
Open
Conversation
domire8
force-pushed
the
revert/assignments
branch
from
04d5189 to
271c9cb
Compare
domire8
force-pushed
the
revert/assignments
branch
from
271c9cb to
894b828
Compare
This reverts commit b8d7f0e.
domire8
force-pushed
the
revert/assignments
branch
from
894b828 to
a307107
Compare
SprGrf
approved these changes
Apr 2, 2026
SprGrf
left a comment
SprGrf
left a comment
There was a problem hiding this comment.
Good for me. I would add the reason why are reverting in the changelog for transparency.
|
|
||
| /** | ||
| * @brief Populate a Predicate message with the name and the value of a predicate. | ||
| * @brief Populate a Prediate message with the name and the value of a predicate. |
There was a problem hiding this comment.
Suggested change
| * @brief Populate a Prediate message with the name and the value of a predicate. | |
| * @brief Populate a Predicate message with the name and the value of a predicate. |
|
|
||
| /** | ||
| * @brief Populate a Predicate message with the name and the value of a predicate. | ||
| * @brief Populate a Prediate message with the name and the value of a predicate. |
There was a problem hiding this comment.
Suggested change
| * @brief Populate a Prediate message with the name and the value of a predicate. | |
| * @brief Populate a Predicate message with the name and the value of a predicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As described, this PR will just fast forward the commits without squashing
Review guidelines
Estimated Time of Review: 10 minutes
Checklist before merging:
Related issues
Blocked by: